-
Notifications
You must be signed in to change notification settings - Fork 4.4k
feat(ec2): add VPC interface endpoints for Cognito Identity #36789
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
aws-cdk-automation
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The pull request linter fails with the following errors:
❌ Features must contain a change to a README file.
❌ Features must contain a change to a test file.
❌ Features must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
|
Comments on closed issues and PRs are hard for our team to see. |
|
This issue has been reopened and is now available for discussion. |
281262a to
673d491
Compare
99d59d2 to
1dc66cb
Compare
badmintoncryer
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your contribution!
|
Exemption request. We don't need any tests and documentation about this modification. |
Issue # (if applicable)
None
Reason for this change
Cognito Identity supports interface VPC endpoints, but they are currently missing from the AWS CDK's InterfaceVpcEndpointAwsService.
Description of changes
Add interface VPC endpoints
COGNITO_IDENTITYCOGNITO_IDENTITY_FIPSDescribe any new or updated permissions being added
None
Description of how you validated changes
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license