fix(ec2): fixing vpc endpoint for eu-isoe-west-1 region#37596
Open
fix(ec2): fixing vpc endpoint for eu-isoe-west-1 region#37596
Conversation
aws-cdk-automation
requested changes
Apr 14, 2026
Collaborator
There was a problem hiding this comment.
The pull request linter fails with the following errors:
❌ Fixes must contain a change to an integration test file and the resulting snapshot.
If you believe this pull request should receive an exemption, please comment and provide a justification. A comment requesting an exemption should contain the text Exemption Request. Additionally, if clarification is needed, add Clarification Request to a comment.
✅ A exemption request has been requested. Please wait for a maintainer's review.
Contributor
Author
|
Exemption Request: As this is an isolated region, integration tests could not be added. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue # (if applicable)
Closes #31690.
Reason for this change
When deploying a stack that creates VPC interface endpoints in the
eu-isoe-west-1region, the generated endpointis incorrect. The endpoint uses the default
com.amazonawsprefix, buteu-isoe-west-1region requires theuk.adc-e.cloudprefix.For example, in
eu-isoe-west-1, the ECR Docker endpoint should beuk.adc-e.cloud.eu-isoe-west-1.ecr.dkrBut CDK produces
com.amazonaws.eu-isoe-west-1.ecr.dkrThis causes a CloudFormation deployment failure:
This PR updates the prefix for
eu-isoe-west-1region to fix this issue.Description of changes
Fixed the VPC endpoint prefix for
eu-isoe-west-1region and added unit-tests.As this is an isolated region, integration tests have not been added.
I was not able to get the complete list of endpoints using
aws ec2 describe-vpc-endpoint-services --query 'ServiceNames'as I don't have access to this isolated region but someone with access helped confirm that for these 4 endpoints, they differ from the standard VPCE pattern - (com.amazon.eu-isoe-west-1.*)Describe any new or updated permissions being added
N/A
Description of how you validated changes
Validated unit-tests
Checklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache-2.0 license