Skip to content

Tighten history file permissions#10028

Merged
AndrewAsseily merged 5 commits intoaws:developfrom
AndrewAsseily:fix/history-file-permissions-v1
Feb 12, 2026
Merged

Tighten history file permissions#10028
AndrewAsseily merged 5 commits intoaws:developfrom
AndrewAsseily:fix/history-file-permissions-v1

Conversation

@AndrewAsseily
Copy link
Copy Markdown
Contributor

@AndrewAsseily AndrewAsseily commented Jan 28, 2026

Issue #, if available: N/A

Description of changes: Use specific permissions. Changes apply to: CLI history database.

Description of tests: Permission tests use the @skip_if_windows decorator since Unix permission bits don't apply to Windows. Windows relies on ACL inheritance from parent directories instead. The CI pipeline skips these tests on Windows builds as intended.

By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Jan 28, 2026

Codecov Report

❌ Patch coverage is 92.50000% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 93.40%. Comparing base (c4681b5) to head (26021d4).
⚠️ Report is 125 commits behind head on develop.

Files with missing lines Patch % Lines
awscli/customizations/history/db.py 87.50% 3 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##           develop   #10028      +/-   ##
===========================================
+ Coverage    93.39%   93.40%   +0.01%     
===========================================
  Files          210      210              
  Lines        17052    17139      +87     
===========================================
+ Hits         15925    16009      +84     
- Misses        1127     1130       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@AndrewAsseily AndrewAsseily merged commit 95853a2 into aws:develop Feb 12, 2026
48 checks passed
aws-sdk-python-automation added a commit that referenced this pull request Feb 12, 2026
* release-1.44.38:
  Bumping version to 1.44.38
  Update changelog based on model updates
  Tighten history file permissions (#10028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants