Add short aliases to some S3 command options#9984
Open
EpicWink wants to merge 2 commits intoaws:developfrom
Open
Add short aliases to some S3 command options#9984EpicWink wants to merge 2 commits intoaws:developfrom
EpicWink wants to merge 2 commits intoaws:developfrom
Conversation
Author
|
I've added support for short options to the completer, but it assumes all 1-length options are short, and it also changes the logic (instead of stripping the leading hyphens from the argument, it pre-pends hyphens to all available options). It would be simpler to remove support in the completer: did you want this? I've left this merge request as multiple commits until this question is resolved (to make it easier to revert). |
EpicWink
force-pushed
the
s3-short-params
branch
3 times, most recently
from
166b899 to
80a0a07
Compare
Aliases as specified with name. Single-letter aliases are prefixed with
a single hyphen, otherwise with two hyphens. ValueError is raised when
positional argument defines aliases.
Aliases are:
* '-r' for '--recursive' ('s3 cp', 's3 ls', 's3 mv', 's3 rm')
* '-H' for '--human-readable' ('s3 ls')
* '-s' for '--summarize' ('s3 ls')
* '-n' for '--dryrun' ('s3 cp', 's3 mv', 's3 rm')
EpicWink
force-pushed
the
s3-short-params
branch
from
80a0a07 to
0f78426
Compare
EpicWink
commented
Mar 11, 2026
| ( | ||
| self.operations_called[idx][1]['CopySource']['Key'], | ||
| self.operations_called[idx][1]['Key'], | ||
| self.operations_called[delete_indexes[i]][1]['Key'], |
Author
There was a problem hiding this comment.
This causes the test to be flakey
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Aliases as specified with name. Single-letter aliases are prefixed with a single hyphen, otherwise with two hyphens.
ValueErroris raised when positional argument defines aliases.Aliases are:
-rfor--recursive(s3 cp,s3 ls,s3 mv,s3 rm)-Hfor--human-readable(s3 ls)-sfor--summarize(s3 ls)-nfor--dryrun(s3 cp,s3 mv,s3 rm)Resolves #9972