feat: #6929 add ResourcePrefix to imagebuilder#7036
Open
Mideky-hub wants to merge 1 commit intoaws:developfrom
Open
feat: #6929 add ResourcePrefix to imagebuilder#7036Mideky-hub wants to merge 1 commit intoaws:developfrom
Mideky-hub wants to merge 1 commit intoaws:developfrom
Conversation
Author
|
up |
Author
|
Hello @demartinofra, sorry to bother but can you take a look at this ? 😄 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
resource_prefiexin theImageBuildermodule.resource_prefiexvalue specified in the configuration is respected during image creation, aligning behavior with what’s currently expected in cluster builds.resource_prefiexwas ignored in theImageBuilder, leading to inconsistencies and user confusion as reported in issue [#6929](Feature Request: Support "ResourcePrefix:" argument for image-builder pipeline #6929).Tests
Automated Tests:
resource_prefiexis provided.resource_prefiexis set and when omitted (default behavior).Manual Tests:
pcluster build-imageusing a configuration that includesresource_prefiex, validated that it is correctly applied throughout the image build lifecycle.References
ImageBuildercomponentChecklist
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.