[Test] Reduce the risk of ICEs in test_update_slurm by setting more flexible instance types#7256
Merged
gmarciani merged 7 commits intoaws:integ-tests-3.14.2from Mar 2, 2026
Conversation
… flexible instance types.
…e types, enforce that they support both on-demand and spot usage classes.
gmarciani
changed the title
gmarciani
added
skip-changelog-update
himani2411
previously approved these changes
Mar 2, 2026
gmarciani
added
the
skip-security-exclusions-check
gmarciani
changed the title
gmarciani
force-pushed
the
wip/mgiacomo/integ3142-flex-instance-0302
branch
from
0648897 to
a4493c9
Compare
gmarciani
changed the title
gmarciani
removed
the
skip-security-exclusions-check
… was detecting false positives. The rule B105 is meant to detect secrets in code and identifies "token" as a secret string, which is not the case in these files.
gmarciani
added
the
skip-security-exclusions-check
himani2411
approved these changes
Mar 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of changes
Cherry-picked:
[Test] Reduce the risk of ICEs in
test_update_slurmby setting more flexible instance types. #7213 to reduce the risk of ICEs in test_update_slurm by setting more flexible instance types.Before this change the test was using up to 2 instance types, which exposes the test to ICEs.
With this change we are using 5 different flexible instance types.
Do not use older generation instance types when retrieving similar instance types #7235: to address linter failures and prevent to run retired instance types when using the fixture to inject flex instance types.
Tests
Tested in original PR.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.