fix: handle intrinsic functions in Lambda FunctionName for GetAtt resolution#8820
Open
hoangsetup wants to merge 1 commit intoaws:developfrom
Open
fix: handle intrinsic functions in Lambda FunctionName for GetAtt resolution#8820hoangsetup wants to merge 1 commit intoaws:developfrom
hoangsetup wants to merge 1 commit intoaws:developfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue(s) does this change fix?
Fixes #6868, #5916, #4597
Fixes Lambda function mounting issue where
Fn::JoincontainingFn::GetAttfor Lambda Integration URIs in API Gateway Method resources shows "Mounting None" instead of the actual function name.Affected Use Case:
Previously showed:
Mounting None❌Now shows:
Mounting HelloWorldFunction at http://127.0.0.1:3000/hello [GET]✅Why is this change necessary?
When developers use
Fn::JoinwithFn::GetAttto construct Lambda Integration URIs (a common CloudFormation pattern), SAM CLI failed to mount the Lambda function correctly, showing:This prevented developers from:
Fn::JoinandFn::Sub(which worked correctly)The bug was particularly confusing because
Fn::Subworked fine, leading developers to believe their template was wrong when it was actually a SAM CLI bug.How does it address the issue?
What side effects does this change have?
Positive effects:
Fn::JoinwithFn::GetAttnow works correctly for Lambda Integration URIsFunctionNamecontains intrinsic functionsFn::JoinandFn::SubapproachesNo negative effects:
Mandatory Checklist
PRs will only be reviewed after checklist is complete
make prpassesmake update-reproducible-reqsif dependencies were changedBy submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.