Skip to content

Add configuration option to allow customizing the internal execu…#6680

Merged
zoewangg merged 5 commits intomasterfrom
zoewang/cw-allowConfigureQueueBehavior
Feb 3, 2026
Merged

Add configuration option to allow customizing the internal execu…#6680
zoewangg merged 5 commits intomasterfrom
zoewang/cw-allowConfigureQueueBehavior

Conversation

@zoewangg
Copy link
Copy Markdown
Contributor

@zoewangg zoewangg commented Jan 21, 2026

Motivation and Context

Customers with high-throughput applications may experience dropped metrics because the internal executor queue fills up faster than metrics can be aggregated. The warning "Some AWS SDK client-side metrics have been dropped..." appears frequently

This change allows customers to configure the internal BlockingQueue used by the CloudWatchMetricPublisher, addressing the gap.

Modifications

  • Added taskQueue(BlockingQueue<Runnable>) builder method to CloudWatchMetricPublisher.Builder

Testing

  • Added taskQueueSettingIsHonored() test that verifies the custom queue is used by spying on the queue and verifying
    offer() is called
  • Existing tests continue to pass

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

Checklist

  • I have read the CONTRIBUTING document
  • Local run of mvn install succeeds
  • My code follows the code style of this project
  • My change requires a change to the Javadoc documentation
  • I have updated the Javadoc documentation accordingly
  • I have added tests to cover my changes
  • All new and existing tests passed
  • I have added a changelog entry. Adding a new entry must be accomplished by running the scripts/new-change script
    and following the instructions. Commit the new file created by the script in .changes/next-release with your changes.
  • My change is to implement 1.11 parity feature and I have updated [LaunchChangelog](https://github.com/aws/aws-sdk-
    java-v2/blob/master/docs/LaunchChangelog.md)

License

  • I confirm that this pull request can be released under the Apache 2 license

@zoewangg zoewangg requested a review from a team as a code owner January 21, 2026 22:18
@zoewangg zoewangg added the api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team label Jan 26, 2026
@zoewangg zoewangg enabled auto-merge January 26, 2026 17:39
@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud Bot commented Feb 3, 2026

Quality Gate Failed Quality Gate failed

Failed conditions
8.9% Duplication on New Code (required ≤ 3%)

See analysis details on SonarQube Cloud

@zoewangg zoewangg added this pull request to the merge queue Feb 3, 2026
Merged via the queue into master with commit c216ced Feb 3, 2026
39 of 40 checks passed
@github-actions
Copy link
Copy Markdown

github-actions Bot commented Feb 3, 2026

This pull request has been closed and the conversation has been locked. Comments on closed PRs are hard for our team to see. If you need more assistance, please open a new issue that references this one.

@github-actions github-actions Bot locked as resolved and limited conversation to collaborators Feb 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api-surface-area-approved-by-team Indicate API surface area introduced by this PR has been approved by team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants