Conversation
Contributor
✅ No Breaking Changes DetectedNo public API breaking changes found in this PR. |
awsarron
approved these changes
Apr 10, 2026
notgitika
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
fix: replace blocklist with allowlist for install_packages() package validation
The previous character blocklist (;, &, |, `, $) could be bypassed by passing pip flags like -r or --index-url as separate list elements, which contained none of the blocked characters but still reached the shell command string. Replace it with a regex allowlist (VALID_PACKAGE_NAME) that only accepts strings matching valid PyPI package name syntax, blocking all flag and path injection vectors at the input boundary. Add TestInstallPackagesAllowlist covering pip flags, shell metacharacters, path traversal, newline splitting, and valid package specs.