Add FTP Capacity Block Expiration Notification Feature into 1.0#157
Merged
Add FTP Capacity Block Expiration Notification Feature into 1.0#157
Conversation
skazantsev
previously approved these changes
Feb 24, 2026
aws-ajangg
reviewed
Feb 25, 2026
| + // Show notification based on severity | ||
| + switch (severity) { | ||
| + case NotificationSeverity.Error: | ||
| + // selectedAction = await vscode.window.showErrorMessage( |
There was a problem hiding this comment.
nit: should these error messages that are commented out be cleaned up?
Author
There was a problem hiding this comment.
Removed those commented out notification messages
|
Otherwise, LGTM |
aakashmandavilli96
approved these changes
Feb 26, 2026
aakashmandavilli96
pushed a commit
to aakashmandavilli96/code-editor
that referenced
this pull request
Feb 26, 2026
**Description** - Update SageMaker CodeEditor Version to 1.8.5 to display on UI **Motivation** - New version launch based on this PR : aws#157
azmkercso
pushed a commit
that referenced
this pull request
Feb 26, 2026
**Description** - Update SageMaker CodeEditor Version to 1.8.5 to display on UI **Motivation** - New version launch based on this PR : #157
Removed commented-out error and warning message code from notificationManager.ts.
skazantsev
approved these changes
Feb 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Issue
Description of Changes
Implements FTP Capacity Block Expiration Notification feature for SageMaker extension. Adds three-tier notification system (30min, 10min, 2min warnings) to alert users before capacity block expiration, preventing unexpected data loss.
Key additions:
Technical highlights:
Testing
Tested via GitHub Actions workflow on feature branch with DISABLE_MANGLE=true. Build artifacts generated successfully. Verified notification scheduling logic and timeout handling.
Screenshots/Videos
Additional Notes
Changes limited to SageMaker-specific directories (patches/sagemaker/), enabling SageMaker team self-approval per CODEOWNERS. Feature enhances UX by preventing data loss during capacity block expiration with defensive error handling and graceful degradation.
Backporting
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.