Conversation
| @@ -0,0 +1,12 @@ | |||
| [package] | |||
| name = "determinizable-collections" | |||
There was a problem hiding this comment.
Let's just stick to deterministic-collections
"determinizable" sounds like it's capable of being made deterministic, but these collections already behave deterministically
There was a problem hiding this comment.
Actually, I would be fine with shuttle_collections (or shuttle-collections) too
There was a problem hiding this comment.
"determinizable" sounds like it's capable of being made deterministic, but these collections already behave deterministically
This is capable of being made deterministic via the deterministic flag,. If it is not provided then this will not behave deterministically.
There was a problem hiding this comment.
Okay, then the crate name should be "determinizable_collections" to match the package name.
There was a problem hiding this comment.
Since you agree, could you please make the change, and let's merge this?
There was a problem hiding this comment.
But I have made the change, no? https://github.com/awslabs/shuttle/pull/235/files#diff-68b6f98c9864877d15e24c65ebf70cd6b1adf1b28f9c2616668e2bdc1cc48a5dR2
| //! determinizable-collections = { version = "0.0.1", features = deterministic } | ||
| //! ``` | ||
| //! | ||
| //! Some applications may want to have deterministic collections in their pre-prod environments, |
There was a problem hiding this comment.
What are "pro-prod environments"? Replace with "test environments"
There was a problem hiding this comment.
Not sure I see the issue with "pre-prod environments", pre-prod (or pre prod) has in my experience been the word used for any environment where code is run but without it affecting (all) customers. This encompasses testing environments, staging environments, development environments and so on for whichever environments the code is run.
Updated to pre-production.
sarsko
force-pushed
the
det-pr
branch
3 times, most recently
from
88894a0 to
b2eaab7
Compare
|
Made into draft because I'll try out the overriding weak symbols approach |
Co-authored-by: Aurea <Aurel300@users.noreply.github.com> Co-authored-by: Bernhard Kragl <kraglb@amazon.com>
|
Undrafted since the weak symbols approach did not work. |
|
Merging since the only change since approval by Rajeev is rebasing. |
2 participants
Adds deterministic hash collections
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.