[GIT PULL] remove unused linux/dma-buf.h include#1551
Merged
axboe merged 1 commit intoaxboe:masterfrom Mar 17, 2026
Merged
Conversation
The header is not used and indirectly pulls in <linux/if.h>, which conflicts with <net/if.h> in userspace builds. Drop the unused include to avoid the header conflict and reduce unnecessary dependencies. Signed-off-by: Zile Xiong <xiongzile@bytedance.com>
Collaborator
|
On 3/17/26 16:49, Zile Xiong wrote:
This pull request removes an unused <linux/dma-buf.h> include from
examples/zcrx.c.
The header is not needed and indirectly pulls in <linux/if.h>, which
can conflict with <net/if.h> in userspace builds and lead to
redefinition errors.
I'm very confused how linux/dma-buf.h happens to include if.h. Can you
paste the compilation error? Because we have bigger problems if it's
not allowed to include basic linux headers.
…--
Pavel Begunkov
|
Contributor
Author
This was my mistake. My local kernel headers are modified so that The include in examples/zcrx.c is unused. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request removes an unused <linux/dma-buf.h> include from
examples/zcrx.c.
The header is not needed and indirectly pulls in <linux/if.h>, which
can conflict with <net/if.h> in userspace builds and lead to
redefinition errors.
Dropping it avoids the potential build issue and removes an unnecessary
dependency.
git request-pull output:
Click to show/hide pull request guidelines
Pull Request Guidelines
notification, use
[GIT PULL]as a prefix in your PR title.Commit message format rules:
Signed-off-bytag with your real name and email. For example:The description should be word-wrapped at 72 chars. Some things should
not be word-wrapped. They may be some kind of quoted text - long
compiler error messages, oops reports, Link, etc. (things that have a
certain specific format).
Note that all of this goes in the commit message, not in the pull
request text. The pull request text should introduce what this pull
request does, and each commit message should explain the rationale for
why that particular change was made. The git tree is canonical source
of truth, not github.
Each patch should do one thing, and one thing only. If you find yourself
writing an explanation for why a patch is fixing multiple issues, that's
a good indication that the change should be split into separate patches.
If the commit is a fix for an issue, add a
Fixestag with the issueURL.
Don't use GitHub anonymous email like this as the commit author:
Use a real email address!
Commit message example:
By submitting this pull request, I acknowledge that: