Add test and man page updates for non-iopoll uring_cmds on IORING_SETUP_IOPOLL rings#1552
Merged
axboe merged 3 commits intoaxboe:masterfrom Mar 19, 2026
Merged
Conversation
Owner
|
Looks good outside of: Can you fix that one up? |
Kernel commit 23475637b0c4 ("io_uring/uring_cmd: allow non-iopoll cmds
with IORING_SETUP_IOPOLL") queued for 7.1 will allow uring_cmds for
files that don't support iopoll to be issued to IORING_SETUP_IOPOLL
io_urings. Add a test iopoll-sync for this. It sets up an io_uring with
IORING_SETUP_IOPOLL and issues linked SOCKET_URING_OP_{GET,SET}SOCKOPT
uring_cmds.
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Since kernel commit 73911426aaaa ("io_uring: check IOPOLL/ioprio support
upfront"), IORING_OP_NOP is supported with IORING_SETUP_IOPOLL. Remove
the outdated note from the io_uring_enter() man page that it would
result in EINVAL.
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
Kernel commit 23475637b0c4 ("io_uring/uring_cmd: allow non-iopoll cmds
with IORING_SETUP_IOPOLL") queued for 7.1 will allow uring_cmds for
files that don't support iopoll to be issued to IORING_SETUP_IOPOLL
io_urings. Update the io_uring_setup_flags man page to clarify exactly
which opcodes are allowed on IORING_SETUP_IOPOLL io_urings. Update the
io_uring_setup man page to say most non-polled I/O is disallowed, with a
reference to the io_uring_setup_flags page. Also clarify that O_DIRECT
is only required for read and write opcodes.
Signed-off-by: Caleb Sander Mateos <csander@purestorage.com>
d3259ac to
e20dcbb
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As requested...
Add a test (
iopoll-sync) issuing non-iopollSOCKET_URING_OP_{GET,SET}SOCKOPTuring_cmds to anIORING_SETUP_IOPOLLio_uring.Update various man pages to reflect the current set of opcodes supported by the kernel with
IORING_SETUP_IOPOLL.git request-pull output: