register: fix unused parameter warnings#1564
Merged
axboe merged 2 commits intoaxboe:masterfrom Apr 1, 2026
Merged
Conversation
travisdowns
added a commit
to travisdowns/bazel-central-registry
that referenced
this pull request
Apr 1, 2026
Upstream liburing has unused parameters in register.c that trigger -Wunused-parameter from -Wextra. A fix is pending upstream (axboe/liburing#1564) but for this release we suppress the warning with -Wno-unused-parameter.
Owner
|
Change looks good, but you're missing a |
travisdowns
added a commit
to travisdowns/bazel-central-registry
that referenced
this pull request
Apr 1, 2026
Upstream liburing has unused parameters in register.c that trigger -Wunused-parameter from -Wextra. A fix is pending upstream (axboe/liburing#1564) but for this release we suppress the warning with -Wno-unused-parameter.
io_uring_register_wait_reg is a stub returning -EINVAL, so mark its parameters __maybe_unused to avoid -Wunused-parameter warnings. Signed-off-by: Travis Downs <travis.downs@redpanda.com>
The flags parameter is used on the next line, so the annotation is unnecessary. Signed-off-by: Travis Downs <travis.downs@redpanda.com>
travisdowns
force-pushed
the
td-register-unused-params
branch
from
d074b3d to
2a50814
Compare
Contributor
Author
|
@axboe wrote:
Oops! Fixed in force push. |
Owner
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
io_uring_register_wait_regstub as__maybe_unusedto suppress-Wunused-parameterwarnings (the function just returns-EINVAL).__maybe_unusedon theflagsparameter ofio_uring_register_buf_ring, which was originally unused, but today is used unconditionally.