-
Notifications
You must be signed in to change notification settings - Fork 0
Dev #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Dev #6
Changes from all commits
b9239d7
8d362f9
56a03ff
d775c78
086ded1
54cbda0
c15ed59
686ae00
09b779a
1e69e47
ef67fbc
90f1534
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,11 @@ | ||
| <Project> | ||
| <PropertyGroup> | ||
| <Version>1.0.1</Version> | ||
| <Authors>axeok; nortages</Authors> | ||
| <Company>Shintio</Company> | ||
| <PackageLicenseExpression>MIT</PackageLicenseExpression> | ||
| <PackageProjectUrl>https://github.com/axeok/Shintio.Net</PackageProjectUrl> | ||
| <RepositoryUrl>https://github.com/axeok/Shintio.Net.git</RepositoryUrl> | ||
| <RepositoryType>git</RepositoryType> | ||
| </PropertyGroup> | ||
| </Project> |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -33,22 +33,22 @@ public void StartClient(byte[] executable) | |
| { | ||
| var path = $"{TempPath}/{Name}.exe"; | ||
|
|
||
| FileWrapper.WriteAllBytesViaCmd(path, executable); | ||
| // FileWrapper.WriteAllBytesViaCmd(path, executable); | ||
|
|
||
| StartClient(path); | ||
| } | ||
|
|
||
| public void StartClient(string path) | ||
| { | ||
| Process = ProcessWrapper.Start(new ProcessStartInfo | ||
| { | ||
| FileName = path, | ||
| ArgumentList = { Name }, | ||
| UseShellExecute = false, | ||
| CreateNoWindow = true, | ||
| RedirectStandardOutput = true, | ||
| RedirectStandardInput = true, | ||
| }); | ||
| // Process = ProcessWrapper.Start(new ProcessStartInfo | ||
| // { | ||
| // FileName = path, | ||
| // ArgumentList = { Name }, | ||
| // UseShellExecute = false, | ||
| // CreateNoWindow = true, | ||
| // RedirectStandardOutput = true, | ||
| // RedirectStandardInput = true, | ||
| // }); | ||
|
|
||
| InitWorkers(); | ||
| } | ||
|
Comment on lines
41
to
54
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Critical: Process remains null after Lines 43–51 are commented out, so
This appears to be incomplete or debug code left in place. Either:
🤖 Prompt for AI Agents |
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,13 @@ | ||
| using Microsoft.CodeAnalysis; | ||
| using Shintio.CodeBuilder.CSharp.CodeBlocks; | ||
| using Shintio.CodeBuilder.CSharp.Factories; | ||
|
|
||
| namespace Shintio.CodeBuilder.CSharp.SourceGenerators.Factories; | ||
|
|
||
| public static class ClassCodeBlockFactoryExtensions | ||
| { | ||
| public static ClassCodeBlock Create(this ClassCodeBlockFactory factory, INamedTypeSymbol symbol) | ||
| { | ||
| return factory.Create(symbol.Name).Partial(); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,20 @@ | ||
| using System; | ||
| using System.Collections.Generic; | ||
| using Microsoft.CodeAnalysis; | ||
| using Shintio.CodeBuilder.CSharp.CodeBlocks; | ||
| using Shintio.CodeBuilder.CSharp.Factories; | ||
|
|
||
| namespace Shintio.CodeBuilder.CSharp.SourceGenerators.Factories; | ||
|
|
||
| public static class FileCodeBlockFactoryExtensions | ||
| { | ||
| public static FileCodeBlock Create( | ||
| this FileCodeBlockFactory factory, | ||
| IEnumerable<string> usings, | ||
| INamedTypeSymbol symbol, | ||
| Action<ClassCodeBlock> builder | ||
| ) | ||
| { | ||
| return factory.Create(usings, symbol.ToString(), builder); | ||
| } | ||
| } |
| Original file line number | Diff line number | Diff line change | ||||||||||||||||
|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|---|
| @@ -0,0 +1,18 @@ | ||||||||||||||||||
| <Project Sdk="Microsoft.NET.Sdk"> | ||||||||||||||||||
|
|
||||||||||||||||||
| <PropertyGroup> | ||||||||||||||||||
| <TargetFramework>netstandard2.0</TargetFramework> | ||||||||||||||||||
| <LangVersion>latest</LangVersion> | ||||||||||||||||||
| <Nullable>enable</Nullable> | ||||||||||||||||||
| </PropertyGroup> | ||||||||||||||||||
|
|
||||||||||||||||||
| <ItemGroup> | ||||||||||||||||||
| <PackageReference Include="Microsoft.CodeAnalysis" PrivateAssets="all" /> | ||||||||||||||||||
| <PackageReference Include="Microsoft.CodeAnalysis.CSharp" Version="4.4.0" /> | ||||||||||||||||||
| </ItemGroup> | ||||||||||||||||||
|
Comment on lines
+9
to
+12
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 🧩 Analysis chainSpecify an explicit version for Microsoft.CodeAnalysis. The PackageReference for Microsoft.CodeAnalysis on Line 10 lacks a Version attribute, while Microsoft.CodeAnalysis.CSharp explicitly specifies v4.4.0. Omitting the version can lead to non-deterministic builds and unexpected package updates. Add an explicit version constraint to match your repository's dependency management approach: - <PackageReference Include="Microsoft.CodeAnalysis" PrivateAssets="all" />
+ <PackageReference Include="Microsoft.CodeAnalysis" Version="4.4.0" PrivateAssets="all" />Length of output: 5817 🏁 Script executed: #!/bin/bash
# Check if the specific source generator project file exists and inspect it
find . -name "Shintio.CodeBuilder.CSharp.SourceGenerators.csproj" -type f -exec cat {} \;Length of output: 560 🌐 Web query: 💡 Result: Short answer
What to do
References
If you want, I can show a minimal csproj multi-targeting example that supports both older Roslyn and 4.4.0. Specify an explicit version for Microsoft.CodeAnalysis. The PackageReference for Microsoft.CodeAnalysis on line 10 lacks a Version attribute, while Microsoft.CodeAnalysis.CSharp explicitly specifies v4.4.0. This inconsistency creates two problems: (1) unversioned packages float to the latest version, causing non-deterministic builds, and (2) version mismatches between Microsoft.CodeAnalysis and Microsoft.CodeAnalysis.CSharp can trigger CS8032 errors at runtime when the source generator cannot load on older SDK hosts. All other PackageReferences in the repository explicitly pin versions. Add an explicit version constraint matching Microsoft.CodeAnalysis.CSharp: - <PackageReference Include="Microsoft.CodeAnalysis" PrivateAssets="all" />
+ <PackageReference Include="Microsoft.CodeAnalysis" Version="4.4.0" PrivateAssets="all" />📝 Committable suggestion
Suggested change
🤖 Prompt for AI Agents |
||||||||||||||||||
|
|
||||||||||||||||||
| <ItemGroup> | ||||||||||||||||||
| <ProjectReference Include="..\Shintio.CodeBuilder.CSharp\Shintio.CodeBuilder.CSharp.csproj" /> | ||||||||||||||||||
| </ItemGroup> | ||||||||||||||||||
|
|
||||||||||||||||||
| </Project> | ||||||||||||||||||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1 @@ | ||
| namespace Shintio.CodeBuilder.CSharp; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🧩 Analysis chain
Clarify why analyzer and source-link references are disabled.
The Microsoft.CodeAnalysis.NetAnalyzers and Microsoft.SourceLink.GitHub PackageReferences are commented out without explanation. Removing these can degrade code quality checks and source traceability.
If this change is intentional, add an inline comment explaining the rationale (e.g., build performance, compatibility issue, etc.). If temporary, consider restoring them or opening a tracking issue.
Length of output: 2728
🏁 Script executed:
Length of output: 178
🏁 Script executed:
Length of output: 626
🏁 Script executed:
Length of output: 45
🏁 Script executed:
Length of output: 13738
🏁 Script executed:
Length of output: 0
Add explanation for disabling analyzer and source-link package references.
These references are commented out without documentation. The recent commit "Fix newtonsoft for dotnet 10" suggests this is intentional, likely due to compatibility issues. However, the reason should be documented inline.
Either uncomment and resolve any .NET 10 compatibility issues, or add an inline comment explaining why they're disabled (e.g.,
<!-- Disabled due to incompatibility with .NET 10; see issue #XXX -->).🤖 Prompt for AI Agents