This repository was archived by the owner on Apr 14, 2026. It is now read-only.
docs: update AbortSignal.timeout() compatibility note to include modern browsers#325
Closed
alihamzahq wants to merge 1 commit intoaxios:masterfrom
Closed
Conversation
…rn browsers AbortSignal.timeout() is now supported in all modern browsers (Chrome 103+, Firefox 100+, Safari 16+), not just Node.js 17.3+.
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
There was a problem hiding this comment.
No issues found across 1 file
Since this is your first cubic review, here's how it works:
- cubic automatically reviews your code and comments on bugs and improvements
- Teach cubic by replying to its comments. cubic learns from your replies and gets better over time
- Add one-off context when rerunning by tagging
@cubic-dev-aiwith guidance or docs links (includingllms.txt) - Ask questions if you need clarification on any suggestion
alihamzahq
changed the title
Member
|
Thanks for this update, however this repo will be deprecated and archived as we will be keeping the docs in the main repo from here on out. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this PR does
Updates the AbortSignal.timeout() compatibility note in the Cancellation docs.
Why this change is needed
The current docs label AbortSignal.timeout() as [nodejs 17.3+] only, which is
misleading. This API is now supported in all modern browsers:
Changes made
Reference
https://developer.mozilla.org/en-US/docs/Web/API/AbortSignal/timeout_static
Summary by cubic
Clarifies AbortSignal.timeout() support in the Cancellation docs: available in Node.js 17.3+ and all modern browsers (Chrome 103+, Firefox 100+, Safari 16+). Replaces the previous "Node.js only" note.
Written for commit b63e65f. Summary will update on new commits.