Fix sorting in page for translations#526
Open
d-g-codappix wants to merge 4 commits intob13:masterfrom
Open
Conversation
$container->getChildRecords() only used for the condition. We can remove this, because the new getAfterContainerRecord() returns the container itself if ce has no children. We than can check if the uids are equal. This improvement allows to extract the $sorting from the condition so we only have the else block.
d-g-codappix
force-pushed
the
fix_sorting_in_page_for_translations
branch
from
376be64 to
8539644
Compare
Contributor
|
Hi @d-g-codappix , thanks for PR, your CSV-Fixtures setups are not valid for Tests/Functional/Integrity/Fixtures/SortingInPage/container_is_sorted_before_child_of_previous_container_with_nested_changed_children_sorting.csv
for Tests/Functional/Integrity/Fixtures/SortingInPage/container_is_sorted_before_child_of_previous_container_on_translated_page.csv
both files:
|
Contributor
|
additional, i would suggest to drop the language parameter, but autodetect all pages in "Free Mode" (and also run only on these (no connected or mixed mode pages should be considered) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
current behavior:
If pages are translated in the so-called “Free Mode”, then only the sort order in the default language is fixed. The sorting in translated pages is not changed.
expected behavior:
In “Free Mode”, however, the contents are independent of each other and should therefore also be fixed for all languages including the default language.