Open
Conversation
The title `template-set-bridge-partner-threshold` did not correspond to the purpose of the template, and the status was also incorrect. The issue was that the title and status were mistakenly copied from this file: [`template-pause-bridge-base`](https://github.com/0x4tl4nt/contract-deployments/blob/main/setup-templates/template-pause-bridge-base/README.md) ### Changes: - Updated the `README` title to match the directory purpose: `Set Bridge Partner Threshold`. - Assigned `README` status `Status: TEMPLATE`, since the `template-set-bridge-partner-threshold` template is only a draft; `Makefile` copies it but does not run the signature directly. For comparison, the neighboring `template-pause-bridge-base` template is immediately used for signing and has the status `Status: READY TO SIGN`.
Collaborator
🟡 Heimdall Review Status
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The title
template-set-bridge-partner-thresholddid not correspond to the purpose of the template, and the status was also incorrect. The issue was that the title and status were mistakenly copied from this file:template-pause-bridge-baseChanges:
READMEtitle to match the directory purpose:Set Bridge Partner Threshold.READMEstatusStatus: TEMPLATE, since thetemplate-set-bridge-partner-thresholdtemplate is only a draft;Makefilecopies it but does not run the signature directly. For comparison, the neighboringtemplate-pause-bridge-basetemplate is immediately used for signing and has the statusStatus: READY TO SIGN.