fix: SPDX headers in CLAUDE.md; delegate SerializableBranch deserialization to from_gitmodules#36
Conversation
There was a problem hiding this comment.
Copilot wasn't able to review any files in this pull request.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
…ialization to from_gitmodules Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com>
|
Just as a heads up, I was blocked by some firewall rules while working on your feedback. Expand below for details. Warning Firewall rules blocked me from connecting to one or more addresses (expand for details)I tried to connect to the following addresses, but was blocked by firewall rules:
If you need me to access, download, or install something from one of these locations, you can either:
|
There was a problem hiding this comment.
Pull request overview
This PR updates config branch deserialization to use the same parsing rules as .gitmodules conversion and adds SPDX headers to documentation, as follow-up work to PR #33’s review feedback.
Changes:
- Delegate
SerializableBranchdeserialization toGitmodulesConvert::from_gitmodules()and tighten behavior around empty/whitespace values. - Add SPDX header block to
CLAUDE.md.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/options.rs | Adjusts SerializableBranch deserialization to share .gitmodules parsing logic and error on invalid inputs. |
| CLAUDE.md | Adds SPDX header block in the repo’s standard Markdown format. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
…in core areas. (#33) * feat: Add schema; delete old CLAUDE.md for regeneration. * fix: Fixed an issue with toml deserialization due to mismatched expectations between serialize and deserialize forms. Caught by some of the new expanded tests. * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * fix: correct fetchRecurseSubmodules key lookup in from_gitmodules (#34) * Initial plan * fix: use correct fetchRecurseSubmodules key in from_gitmodules with fetchRecurse fallback Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> * fix: SPDX headers in CLAUDE.md; delegate SerializableBranch deserialization to from_gitmodules (#36) * Initial plan * fix: add SPDX headers to CLAUDE.md; delegate SerializableBranch deserialization to from_gitmodules Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Apply suggestions from code review Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> * Relocate branch deserialization test to correct module Moved the test for branch deserialization from TOML to the appropriate test module. * fix: correct TOML deserialization test for SerializableBranch empty/whitespace rejection (#37) * Initial plan * fix: use wrapper struct for branch TOML deserialization test to properly isolate SerializableBranch Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> --------- Co-authored-by: copilot-swe-agent[bot] <198982749+Copilot@users.noreply.github.com> Co-authored-by: bashandbone <89049923+bashandbone@users.noreply.github.com> --------- Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> Co-authored-by: Copilot <198982749+Copilot@users.noreply.github.com>
Two review-driven fixes: missing license headers in
CLAUDE.mdand a deserialization gap inSerializableBranchthat silently accepted invalid input.Changes
CLAUDE.md: Restore SPDXFileCopyrightText+LicenseIdentifierheader block (HTML comment, matchingREADME.md/CONTRIBUTING.mdconvention).SerializableBranch::deserialize: Delegate tofrom_gitmodulesinstead ofFromStr.FromStraccepted empty/whitespace strings, producingName("")silently.from_gitmodulestrims input, rejects empty/whitespace withErr(()), and matches the live superproject branch name as aCurrentInSuperprojectalias.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.