Skip to content

fix: correct TOML deserialization test for SerializableBranch empty/whitespace rejection #37

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bashandbone merged 2 commits into from
Mar 19, 2026
Merged

fix: correct TOML deserialization test for SerializableBranch empty/whitespace rejection #37

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
04e6c29
Initial plan
Copilot Mar 19, 2026
ff0ef4f
fix: use wrapper struct for branch TOML deserialization test to prope…
Copilot Mar 19, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions src/options.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -716,9 +716,15 @@ mod tests {

#[test]
fn test_branch_deserialize_from_toml_rejects_empty_and_whitespace() {
// Use a wrapper struct because TOML top-level must be a table;
// SerializableBranch appears as a field value in real config files.
#[derive(Debug, serde::Deserialize)]
struct Helper {
branch: SerializableBranch,
}

// Empty string should be rejected
let res_empty: Result<SerializableBranch, toml::de::Error> =
toml::from_str("branch = \"\"");
let res_empty: Result<Helper, toml::de::Error> = toml::from_str(r#"branch = """#);
assert!(res_empty.is_err(), "expected error for empty branch value");
Comment on lines 726 to 728
let err_empty = res_empty.unwrap_err().to_string();
assert!(
Expand All @@ -727,8 +733,7 @@ mod tests {
);

// Whitespace-only string should be rejected
let res_ws: Result<SerializableBranch, toml::de::Error> =
toml::from_str("branch = \" \"");
let res_ws: Result<Helper, toml::de::Error> = toml::from_str(r#"branch = " ""#);
assert!(res_ws.is_err(), "expected error for whitespace-only branch value");
let err_ws = res_ws.unwrap_err().to_string();
assert!(
Expand Down
Loading