Merged
Conversation
eval was prob used to expand $VAR refs ini values ie: path =
$HOME/.config
reason for this patch: if say the ini is updated via session_token or
user_input then think of backticks or $() or ! in user_input_pw
envsubst would continue to expand available env vars
unknown vars become empty strings
so key=val of "credentials=user:${NONEXISTENT}" becomes
"credentials=user:"
if a token or password contains $ .. itll be silently empty and literal
but at least not executed
- Known env var: ($HOME) is expanded (OK)
- Unknown env var: ($NONEXISTENT) becomes EMPTY STRING
- string with bang: (!) is passed through as is (OK)
- backticks or exec: (`) or ($()) is passwd through as is (OK)
Member
|
Thank you. Acceptable change. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
eval was prob used to expand $VAR refs ini values ie: path = $HOME/.config
reason for this patch: if say the ini is updated via session_token or user_input then think of backticks or $() or ! in user_input_pw
envsubst would continue to expand available env vars
unknown vars become empty strings
so key=val of "credentials=user:${NONEXISTENT}" becomes "credentials=user:"
if a token or password contains $ .. itll be silently empty and literal but at least not executed