wrap key transform fun in try/catch with Class:Exception clause#231
Open
joecaswell wants to merge 1 commit intodevelop-3.0from
Open
wrap key transform fun in try/catch with Class:Exception clause#231joecaswell wants to merge 1 commit intodevelop-3.0from
joecaswell wants to merge 1 commit intodevelop-3.0from
Conversation
Contributor
|
There are only six places where the transform is called, it looks like. Since either fix will be all in this application, it might make more sense just to fix it all at the call sites. It does look like this will work. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed fix for issue #230 (RIAK-1895) (RIAK-2371)