packages: compute generator_location from the source root#29219
Open
abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
Open
packages: compute generator_location from the source root#29219abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
abishekgiri wants to merge 1 commit intobazelbuild:masterfrom
Conversation
Contributor
Author
|
Reopened this change from the neutral branch name generator-location-fix. The targeted test command is in the PR body; local execution on this machine is still blocked by the unaccepted Xcode license. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This change computes generator_location from the package source root instead of trying to find the package name inside an absolute path with a substring search.
What changed
Root cause
Rule.getRelativeLocation() searched location.toString() for the package name and sliced the string from the first match. That could match unrelated earlier path segments, so short package names like p could produce malformed generator_location values.
Impact
query --output=build now reports stable repository-relative generator_location values even when the package name is a short substring of an earlier absolute-path segment.
Testing
Tried locally:
Current local blocker: