Skip to content

Remove --incompatible_use_cc_configure_from_rules_cc#29268

Closed
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/remove-incompatible_use_cc_configure_from_rules_cc
Closed

Remove --incompatible_use_cc_configure_from_rules_cc#29268
keith wants to merge 1 commit intobazelbuild:masterfrom
keith:ks/remove-incompatible_use_cc_configure_from_rules_cc

Conversation

@keith
Copy link
Copy Markdown
Member

@keith keith commented Apr 10, 2026

Seems to me like this has been obsoleted by a different rules_cc
strategy. cc_configure is already in rules_cc for 9.x+

Closes #10134

@github-actions github-actions bot added team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. awaiting-review PR is awaiting review from an assigned reviewer team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob labels Apr 10, 2026
@meteorcloudy
Copy link
Copy Markdown
Member

Please fix the merge conflict

@keith keith force-pushed the ks/remove-incompatible_use_cc_configure_from_rules_cc branch from e68afed to 35579ad Compare April 15, 2026 16:15
Seems to me like this has been obsoleted by a different rules_cc
strategy. cc_configure is already in rules_cc for 9.x+

Fixes bazelbuild#10134
@keith keith force-pushed the ks/remove-incompatible_use_cc_configure_from_rules_cc branch from 35579ad to 949e8e8 Compare April 15, 2026 16:17
@keith
Copy link
Copy Markdown
Member Author

keith commented Apr 15, 2026

fixed!

@meteorcloudy meteorcloudy added awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally and removed awaiting-review PR is awaiting review from an assigned reviewer labels Apr 16, 2026
@github-actions github-actions bot removed the awaiting-PR-merge PR has been approved by a reviewer and is ready to be merge internally label Apr 16, 2026
@keith keith deleted the ks/remove-incompatible_use_cc_configure_from_rules_cc branch April 16, 2026 16:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

team-ExternalDeps External dependency handling, remote repositiories, WORKSPACE file. team-Loading-API BUILD file and macro processing: labels, package(), visibility, glob team-Rules-API API for writing rules/aspects: providers, runfiles, actions, artifacts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

incompatible_use_cc_configure_from_rules_cc: Use cc_configure from @rules_cc

2 participants