Add strip_components to extract/download_and_extract `http_arch…#29281
Open
willstranton wants to merge 1 commit intobazelbuild:masterfrom
Open
Add strip_components to extract/download_and_extract `http_arch…#29281willstranton wants to merge 1 commit intobazelbuild:masterfrom
strip_components to extract/download_and_extract `http_arch…#29281willstranton wants to merge 1 commit intobazelbuild:masterfrom
Conversation
…ive` The `strip_components` attribute functions similar to tar --strip-components: > Strip NUMBER leading components from file names on extraction. This is an alternative to the existing `strip_prefix` attribute, which required knowing the exact prefix to be stripped. Only one of the two attributes (`strip_prefix`, `strip_components`) can be set at one time. Fixes bazelbuild#28879 RELNOTES[NEW]: Adds the `strip_components` attribute to `extract`/`download_and_extract`/`http_archive` to allow stripping of path components when extracting files.
github-actions
bot
added
team-ExternalDeps
Member
If the source archive URL is deterministic, the exact prefix should be known? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add
strip_componentstoextract/download_and_extracthttp_archiveDescription
The
strip_componentsattribute functions similar totar --strip-components:This is an alternative to the existing
strip_prefixattribute, which required knowing the exact prefix to be stripped. Only one of the two attributes (strip_prefix,strip_components) can be set at one time.Motivation
See #28879
Build API Changes
See #28879
Yes
N/A - this is not a breaking change.
Checklist
Release Notes
RELNOTES[NEW]: Adds the
strip_componentsattribute toextract/download_and_extract/http_archiveto allow stripping of path components when extracting files.