Only set persistentWorkerProtocol for persistent actions#29299
Draft
armandomontanez wants to merge 1 commit intobazelbuild:masterfrom
Draft
Only set persistentWorkerProtocol for persistent actions#29299armandomontanez wants to merge 1 commit intobazelbuild:masterfrom
persistentWorkerProtocol for persistent actions#29299armandomontanez wants to merge 1 commit intobazelbuild:masterfrom
Conversation
The `persistentWorkerProtocol` platform property was unconditionally added to any action with `requires-worker-protocol` in its execution requirements, even when the action was not a remote persistent worker. This could cause unexpected platform properties on regular remote actions. Gate the `persistentWorkerProtocol` property behind `--experimental_remote_mark_tool_inputs` so it's only set when it is needed. Work towards bazelbuild#29267.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
persistentWorkerProtocolplatform property was unconditionally added to any action withrequires-worker-protocolin its execution requirements, even when the action was not a remote persistent worker request. This could cause unexpected platform properties when sent as a non-persistent remote action.Gate the
persistentWorkerProtocolproperty behind--experimental_remote_mark_tool_inputsso it's only set when it is needed.Work towards #29267.
RELNOTES: None