buildifier: add *.BUILD.bazel to the list of analyzed patterns

[chouquette]

Add another pattern to the buildifier template script, in order to handle *.BUILD.bazel files.

[gemini-code-assist]

Summary of Changes

Hello, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request expands the buildifier tool's configuration to include an additional file pattern. By recognizing *.BUILD.bazel files, the change ensures broader application of formatting standards, contributing to improved code consistency and maintainability within Bazel projects.

Highlights

• Buildifier Configuration: Added *.BUILD.bazel to the list of file patterns analyzed by the buildifier script, ensuring these files are now correctly processed for formatting.

Changelog

• buildifier/runner.bash.template
  • Added *.BUILD.bazel to the find command's -o -name options, extending the set of files processed by buildifier.

Activity

• No specific activity (comments, reviews, or progress updates) has been recorded for this pull request yet.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[google-cla]

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

[gemini-code-assist]

Code Review

The pull request correctly adds support for *.BUILD.bazel files to the bash runner script. However, for completeness and consistency, two areas should be addressed. Firstly, the corresponding Windows runner script, buildifier/runner.bat.template, has not been updated to include this new file pattern. This will lead to inconsistent behavior across different operating systems. Secondly, it would be beneficial to add a test case to buildifier/integration_test.sh to verify that files matching *.BUILD.bazel are correctly processed. This will help prevent future regressions.

[gemini-code-assist]

To improve readability and future maintainability, it's helpful to group similar patterns. I suggest reordering the BUILD file patterns to group wildcard suffixes together.

    -o -name '*.BUILD' \
    -o -name '*.BUILD.bazel' \
    -o -name 'BUILD.*.bazel' \
    -o -name 'BUILD.*.oss' \