Add command that updates existing attributes with a select#1460
Open
kisabaka wants to merge 2 commits intobazelbuild:mainfrom
Open
Add command that updates existing attributes with a select#1460kisabaka wants to merge 2 commits intobazelbuild:mainfrom
kisabaka wants to merge 2 commits intobazelbuild:mainfrom
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces the add_select command to buildozer, enabling the addition or update of values within select expressions for both list and scalar attributes. The implementation includes helper functions to manage existing select blocks, handle concatenation with plain lists, and ensure default conditions are present. Feedback was provided to maintain consistency in list sorting by utilizing the attributeMustNotBeSorted check when adding values to list attributes.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Buildtools PR checklist
Description
Adds a command to update attributes with a select.
buildozer 'add_select deps @platforms//os:linux :linux_bar' :fooE.g
Before:
After:
(optional) These changes were tested using the following steps
Steps to reproduce / test the PR changes (if anything besides unit tests).
bazel test //...go test ./edit/...