Skip to content

Add @loader_path/../Frameworks rpath for macOS extensions and ExtensionKit #2895

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
adincebic merged 1 commit into from
Apr 19, 2026
+7 −1
Merged

Add @loader_path/../Frameworks rpath for macOS extensions and ExtensionKit #2895

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion apple/internal/rule_support.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -346,6 +346,7 @@ _RULE_TYPE_DESCRIPTORS = {
# Application.app/Contents/PlugIns/Extension.appex/Contents/Frameworks
# or Application.app/Contents/Frameworks
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
"@executable_path/../../../../Frameworks",
],
),
Expand All @@ -361,7 +362,11 @@ _RULE_TYPE_DESCRIPTORS = {
rpaths = [
# ExtensionKit binaries live in
# Application.app/Contents/Extensions/Extension.appex/Contents/MacOS/Extension
# Frameworks are packaged in Application.app/Contents/Frameworks
# Frameworks are packaged in
# Application.app/Contents/Extensions/Extension.appex/Contents/Frameworks
# or Application.app/Contents/Frameworks
"@executable_path/../Frameworks",
"@loader_path/../Frameworks",
"@executable_path/../../../../Frameworks",
],
),
Expand Down
1 change: 1 addition & 0 deletions test/starlark_tests/macos_extension_tests.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,6 +44,7 @@ def macos_extension_test_suite(name):
binary_test_file = "$CONTENT_ROOT/MacOS/ext",
macho_load_commands_contain = [
"path @executable_path/../Frameworks (offset 12)",
"path @loader_path/../Frameworks (offset 12)",
"path @executable_path/../../../../Frameworks (offset 12)",
],
target_under_test = "//test/starlark_tests/targets_under_test/macos:ext",
Expand Down
Loading