Skip to content

Unwrap pkg_deb rule to enable inherit_attrs #1026

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
mxpv wants to merge 1 commit into
base: main
Choose a base branch
from
+5 −12
Open

Unwrap pkg_deb rule to enable inherit_attrs #1026

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 5 additions & 12 deletions pkg/private/deb/deb.bzl
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,9 +29,12 @@ def _pkg_deb_impl(ctx):
ctx.attr.architecture,
)

out_file = ctx.outputs.out or ctx.actions.declare_file(ctx.attr.name + ".deb")

outputs, output_file, output_name = setup_output_files(
ctx,
package_file_name = package_file_name,
default_output_file = out_file,
)

out_file_name_base = output_name.rsplit(".", 1)[0]
Expand Down Expand Up @@ -181,7 +184,7 @@ def _pkg_deb_impl(ctx):
},
)
output_groups = {
"out": [ctx.outputs.out],
"out": [out_file],
"deb": [output_file],
"changes": [changes_file],
}
Expand All @@ -194,7 +197,7 @@ def _pkg_deb_impl(ctx):
]

# A rule for creating a deb file, see README.md
pkg_deb_impl = rule(
pkg_deb = rule(
implementation = _pkg_deb_impl,
doc = """
Create a Debian package.
Expand Down Expand Up @@ -374,7 +377,6 @@ See https://www.debian.org/doc/debian-policy/ch-files.html#s-config-files.""",
# Common attributes
"out": attr.output(
doc = """See [Common Attributes](#out)""",
mandatory = True,
),
"package_file_name": attr.string(
doc = """See [Common Attributes](#package_file_name).
Expand All @@ -395,12 +397,3 @@ See https://www.debian.org/doc/debian-policy/ch-files.html#s-config-files.""",
},
)

def pkg_deb(name, out = None, **kwargs):
"""@wraps(pkg_deb_impl)."""
if not out:
out = name + ".deb"
pkg_deb_impl(
name = name,
out = out,
**kwargs
)
Loading