Use http_archive for Git hosted dependencies#3882
Open
jesses-canva wants to merge 3 commits intobazelbuild:mainfrom
Open
Use http_archive for Git hosted dependencies#3882jesses-canva wants to merge 3 commits intobazelbuild:mainfrom
jesses-canva wants to merge 3 commits intobazelbuild:mainfrom
Conversation
|
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
1cc65ef to
bb17e1e
Compare
bb17e1e to
fbc1ac2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've found the use of
git_repositoryto download Git-hosted dependencies inCargo.tomlposes some issues for reliability and performance, specifically:--repository_cache), causing excessive traffic to upstream Git servers when switching branches with differences in Git hosted dependencies. At scale this means upstream Git servers are likely to rate limit requests.For this reason we would prefer to use
http_archivewhere possible, even forgitURLs inCargo.toml.This PR adds a step in
cargo-bazelwhere, for Git hosted dependencies, it first attempts to derive a HTTP URL for an equivalent.tar.gzfile that can be given tohttp_archiverule/Httpsource annotation instead, and otherwise fall back to the previousgit_repository/Gitsource annotation.Currently the logic is only implemented for GitHub, but more entries can be added to
GIT_REPO_TO_HTTP_TAR_GZ_MAPPING.The example
examples/all_crate_depshas been modified to use GitHub to download theanyhowcrate, to validate that the expectedhttp_archivereferencing the.tar.gzarchive appears inexamples/all_crate_deps/MODULE.bazel.lock.