Skip to content

bindgen: also support -target#3883

Merged
krasimirgg merged 1 commit intobazelbuild:mainfrom
divVerent:patch-1
Mar 4, 2026
Merged

bindgen: also support -target#3883
krasimirgg merged 1 commit intobazelbuild:mainfrom
divVerent:patch-1

Conversation

@divVerent
Copy link
Contributor

https://clang.llvm.org/docs/ClangCommandLineReference.html:

--target=<arg>, -target <arg>
Generate code for the given target

Both syntaxes are documented for Clang, so let's support both.

@krasimirgg krasimirgg self-requested a review March 4, 2026 14:52
Copy link
Collaborator

@krasimirgg krasimirgg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you!

https://clang.llvm.org/docs/ClangCommandLineReference.html:

    --target=<arg>, -target <arg>
    Generate code for the given target

Both syntaxes are documented for Clang, so let's support both.
@divVerent
Copy link
Contributor Author

Just also added tests for this, let's see if they pass.

@divVerent
Copy link
Contributor Author

Yes, looks like everything passed. Hope the tests this way are OK as well.

@krasimirgg krasimirgg added this pull request to the merge queue Mar 4, 2026
Merged via the queue into bazelbuild:main with commit 43ab785 Mar 4, 2026
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants