Add section warning against catching Throwables#264
Open
NoahTheDuke wants to merge 1 commit intobbatsov:masterfrom
Open
Add section warning against catching Throwables#264NoahTheDuke wants to merge 1 commit intobbatsov:masterfrom
NoahTheDuke wants to merge 1 commit intobbatsov:masterfrom
Conversation
Collaborator
|
I agree with the advice Noah wants to add here (even tho' I'm guilty of catching BTW, I've fixed the codespell failure on the main branch (ignore |
NoahTheDuke
force-pushed
the
nb/catching-throwables
branch
from
51257cc to
ee87d55
Compare
Author
|
I rebased on master to fix the spelling mistake. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I've noticed that many Clojure programmers use
(catch Throwable t ...)as a means of not dealing with Exceptions. However, this is poor Java practice given that Errors are generally treated as "the application should fail" situations. As such, I think it would be nice to have a recommendation against using(catch Throwable t ...)alongside a nudge towards using explicit Error and Exception classes in catch clauses.cf: Blind Rescues in the Ruby Style Guide, the recommendation of the Java Docs on Errors.