Skip to content

Suppress notification when user manually closes a task#396

Open
bborn wants to merge 1 commit intomainfrom
task/1044-dont-trigger-a-notification-when-i-close
Open

Suppress notification when user manually closes a task#396
bborn wants to merge 1 commit intomainfrom
task/1044-dont-trigger-a-notification-when-i-close

Conversation

@bborn
Copy link
Owner

@bborn bborn commented Feb 6, 2026

Summary

  • When the user closes a task from the UI, the yellow "Task complete" notification and terminal bell no longer trigger
  • Background task completions (e.g., via the executor) still show the notification as before
  • Tracks user-closed task IDs in a map so the event handler can distinguish user-initiated closes from background completions

Test plan

  • Close a task from the UI — verify no yellow notification appears
  • Let a task complete in the background — verify the notification still appears
  • Run go test ./... — all tests pass

🤖 Generated with Claude Code

When the user closes a task from the UI, the status change event
was triggering a yellow "Task complete" notification and terminal
bell, which is redundant since the user just performed that action.

Track user-closed task IDs so the event handler can skip the
notification for those tasks while still showing it for tasks
that complete in the background (e.g., via the executor).

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant