Add support for many=True on create#151
Open
feelixe wants to merge 2 commits intobeda-software:masterfrom
Open
Add support for many=True on create#151feelixe wants to merge 2 commits intobeda-software:masterfrom
feelixe wants to merge 2 commits intobeda-software:masterfrom
Conversation
Codecov Report
@@ Coverage Diff @@
## master #151 +/- ##
==========================================
- Coverage 98.16% 96.18% -1.99%
==========================================
Files 3 3
Lines 218 262 +44
==========================================
+ Hits 214 252 +38
- Misses 4 10 +6
Continue to review full report at Codecov.
|
|
Does the |
auvipy
suggested changes
Aug 2, 2025
auvipy
left a comment
There was a problem hiding this comment.
why not also add the code examples as tests to verify the changes?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds support for initializing serializer with many=True. Works for create, not update.
The current exception when attempting
many=Truein the master branch is thatinitial_datais not set.So basically, I've created a ListSerializer
BaseNestedListSerializer. And assign this inBaseNestedModelSerializerin methodmany_init. The list serializer then iterates overself.get_initial()and setsinitial_dataon the child serializer. I've tried running this in my project and so far I've not experienced any problems.I would love some help to review this and if there are some improvements that can be made and what steps need to be taken for a merge.
Example usage (Same as current usage, except if you want to use many=True, you have to instantiate the serializer with that kwarg):
serializers.py
views.py
Or to allow for sending one or many: