zero plugin zeroes disctotal if single disc
#6306
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When
omit_single_discis set,disctotalis now also zeroed alongsidedisc. These tags work together ("Disc 2 of 3") so keeping one without the other is inconsistent.Previously, only the
disctag was zeroed. This follows from #6015 which made it into v2.5.1 and added theomit_single_discoption.I've added tests and have used this locally for some time. Happy to add documentation (
zero.rst) and changelog updates if maintainers think it's warranted.To Do