Initial machine translations. #18
Conversation
|
At this point, the translations and translation code should all be active; moving to ready for review. I'm about to get on a plane; merge at your convenience. |
kattni
left a comment
kattni
left a comment
There was a problem hiding this comment.
@freakboy3742 Two things, on one of which your opinion would be appreciated. See inline.
docs/en/contributing/index.md
Outdated
| There are plenty of ways to contribute to BeeWare. The [contribution guide](guide/index.md) covers everything you need to know to provide your contribution. | ||
|
|
||
| ## [Sprints](sprint-guide.md) | ||
| ## [Sprints](sprint-guide.md) { #sprints } |
There was a problem hiding this comment.
The Sprint Guide itself has #sprints as the H1 title anchor. It'll pick the closest one, but, I don't know what that technically means. We shouldn't have it in both places. Which would you prefer the anchor link to?
There was a problem hiding this comment.
Ah - I missed the significance of that in my enthusiasm. I'd say the sprint guide itself is the much more useful anchor.
| } | ||
|
|
||
| a.docs-tutorial-button { | ||
| a.docs-tutorial { |
There was a problem hiding this comment.
You blasted -button from this as well. :) I'll push the fix after I get an answer on the sprints anchor.
There was a problem hiding this comment.
Fix was to update the reference in the div itself. That's why this is not showing outdated.
|
@freakboy3742 I'm not certain why the RTD builds aren't showing up in the CI status. They were triggered and built successfully (https://app.readthedocs.org/projects/beewareorg/builds/31326980/ for example). I'm going to merge this. If something is wonky, we can address it in a subsequent PR. |
2 participants
The full set of initial machine translations.
Includes some minor tweaks to tox configs for consistency.
PR Checklist: