Conversation
rishyak
left a comment
rishyak
left a comment
There was a problem hiding this comment.
Claus, this PR attempts to do too much at once. You have burried Apple Clang fixes, the stated goal of this PR, under a complete infrastructure overhaul (FetchContent, CI rewrites, formatting, and build system changes).
I cannot review the Apple Clang support amidst these unrelated changes. Please close this PR and submit each of your proposed changes as standalone patches. Then, @nickelpro and I will review them.
Regarding the infra changes: I understand this is an effort to align with Beman infra standards, but that certainly needs to be a separate PR where we can discuss the implications.
| include_guard(GLOBAL) | ||
|
|
||
| # Prevent PATH collision with an LLVM clang installation by using the system | ||
| # compiler shims |
There was a problem hiding this comment.
The code is very clear on what it does. We do not need to explain why we do that. This comment is not required.
There was a problem hiding this comment.
Merged with infra contents only😇
|
But how to split what belongs together? |
2 participants
Description
Use the beman infra repo and CI workflow
Related Issues
Motivation and Context
To be compliant with beman standard
Testing
With CI and local on MAC OSX cmake presets
Meta