Closed
Conversation
Update the infra and conform to the patterns produced by the beman cookiecutter. Clean up warnings from GCC.
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
Comment on lines
+34
to
+35
| beman.cstring_view | ||
| PUBLIC FILE_SET HEADERS BASE_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/include" |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| beman.cstring_view | |
| PUBLIC FILE_SET HEADERS BASE_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/include" | |
| beman.cstring_view | |
| PUBLIC FILE_SET HEADERS BASE_DIRS "${CMAKE_CURRENT_SOURCE_DIR}/include" |
Comment on lines
+39
to
+40
| beman.cstring_view | ||
| PROPERTIES VERIFY_INTERFACE_HEADER_SETS ${PROJECT_IS_TOP_LEVEL} |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| beman.cstring_view | |
| PROPERTIES VERIFY_INTERFACE_HEADER_SETS ${PROJECT_IS_TOP_LEVEL} | |
| beman.cstring_view | |
| PROPERTIES VERIFY_INTERFACE_HEADER_SETS ${PROJECT_IS_TOP_LEVEL} |
Comment on lines
+48
to
+49
| enable_testing() | ||
| add_subdirectory(tests/beman/cstring_view) |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| enable_testing() | |
| add_subdirectory(tests/beman/cstring_view) | |
| enable_testing() | |
| add_subdirectory(tests/beman/cstring_view) |
|
|
||
| if(BEMAN_CSTRING_VIEW_BUILD_EXAMPLES) | ||
| add_subdirectory(examples) | ||
| add_subdirectory(examples) |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| add_subdirectory(examples) | |
| add_subdirectory(examples) |
Comment on lines
+77
to
+81
| constexpr cstring_view operator""csv(const char* str, size_t len) noexcept; | ||
| constexpr u8cstring_view operator""csv(const char8_t* str, size_t len) noexcept; | ||
| constexpr u16cstring_view operator""csv(const char16_t* str, size_t len) noexcept; | ||
| constexpr u32cstring_view operator""csv(const char32_t* str, size_t len) noexcept; | ||
| constexpr wcstring_view operator""csv(const wchar_t* str, size_t len) noexcept; |
There was a problem hiding this comment.
[pre-commit] reported by reviewdog 🐶
Suggested change
| constexpr cstring_view operator""csv(const char* str, size_t len) noexcept; | |
| constexpr u8cstring_view operator""csv(const char8_t* str, size_t len) noexcept; | |
| constexpr u16cstring_view operator""csv(const char16_t* str, size_t len) noexcept; | |
| constexpr u32cstring_view operator""csv(const char32_t* str, size_t len) noexcept; | |
| constexpr wcstring_view operator""csv(const wchar_t* str, size_t len) noexcept; | |
| constexpr cstring_view operator"" csv(const char* str, size_t len) noexcept; | |
| constexpr u8cstring_view operator"" csv(const char8_t* str, size_t len) noexcept; | |
| constexpr u16cstring_view operator"" csv(const char16_t* str, size_t len) noexcept; | |
| constexpr u32cstring_view operator"" csv(const char32_t* str, size_t len) noexcept; | |
| constexpr wcstring_view operator"" csv(const wchar_t* str, size_t len) noexcept; |
Member
|
I'll take over making this change. |
Member
|
Superseded by #17 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bring the project up to the current model with beman infra.