feat: add standardization as parameter for dataset#21
Open
Conversation
agramfort
reviewed
Nov 3, 2022
agramfort
left a comment
agramfort
left a comment
There was a problem hiding this comment.
no objection. Do you expect different stories and results here?
Collaborator
Author
Compared with having no standardization? It certainly depends on the dataset, but often yes. Newton-based methods for instance perform better compared to gradient-based methods when the scales of features vary. The support may also vary greatly depending on whether you're standardizing or not. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This pull request sets standardize as a parameter for each of the three datasets, which @mathurinm recommended sometime and I think seems like the right thing to do.