Merged
Conversation
3d1eba6 to
ad6ebb2
Compare
ad6ebb2 to
91c392e
Compare
diefans
approved these changes
Apr 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It feels a bit naughty to have warnings show on the install, so I was thinking to add a lint check to prevent them for the case of future changes
I found the way to do it in https://rust-unofficial.github.io/patterns/anti_patterns/deny-warnings.html
It does state that new warnings might pop up with new rust versions and deps, including deprecations so I figured
RUSTFLAGS="-D all" cargo checkmight cause too much friction.Maybe there are more to added... but I guess clippy has our back for most issues.
I feel it's nicer not to add it to the code because it gets in the way of iteration