Update Rodio to 0.22 by mnmaita · Pull Request #20323 · bevyengine/bevy

mnmaita · 2025-07-29T10:14:28Z

Objective

Closes Update cpal requirement from 0.15 to 0.16 #19672

Solution

Updated both cpal and rodio to their latest versions.
Updated code to address rodio's breaking changes.
Reworked audio related feature flags. NOTE: symphonia will only be the default backend for formats with no alternative fallback.
Added audio-all-formats feature collection to easily enable all the available audio formats using their default backends.
Replaced aarch64-apple-ios-sim target with arm64-apple-ios-simulator.

Testing

Tested audio related examples.
CI checks passing.

mnmaita · 2025-07-29T10:16:56Z

github-actions · 2025-07-29T20:39:42Z

It looks like your PR is a breaking change, but you didn't provide a migration guide.

Please review the instructions for writing migration guides, then expand or revise the content in the migration guides directory to reflect your changes.

nyfair · 2025-10-16T17:49:02Z

Symphonia released 0.5.5 last week, and bevy_audio picks it up by default after cargo update. However, the combination of rodio 0.20 and symphonia 0.5.5 causes a panic when decoding MPEG-4 streams.

This bug can be verified by running this rodio example directly
https://github.com/RustAudio/rodio/blob/v0.20.1/examples/music_m4a.rs

I suggest either merging this PR or pinning the symphonia dependency to version 0.5.4 in Cargo.toml.

mnmaita · 2025-10-22T09:57:51Z

@nyfair this PR is quite broken so I wouldn't merge it yet. We could do the version pinning as a stopgap and leave a comment on said change to fix it later. I might have some time to update this PR in a couple of days so I'll try my best to finalize it soon. @alice-i-cecile in the meantime, would you be able to help me figuring out the 3rd, 4th and 5th items that I left in my comment?

mnmaita · 2025-10-22T13:55:45Z

crates/bevy_audio/src/audio_source.rs

+    /// which iterates over samples of type [`rodio::Sample`].
    /// Must be a [`rodio::Source`] so that it can provide information on the audio it is iterating over.
-    type Decoder: rodio::Source + Send + Iterator<Item = Self::DecoderItem>;
+    type Decoder: rodio::Source + Send + Iterator<Item = rodio::Sample>;


rodio::Source has Iterator<Item = rodio::Sample> as a bound as far as I can see, should we drop this redundant bound or should we keep it?

alice-i-cecile

We shouldn't be exposing minimp3 at all, per #20183

github-actions · 2025-10-29T19:35:47Z

You added a new feature but didn't update the readme. Please run cargo run -p build-templated-pages -- update features to update it, and commit the file change.

alice-i-cecile · 2025-12-10T19:54:01Z

Can you please resolve merge conflicts and get CI passing?

mnmaita · 2025-12-10T22:43:05Z

Can you please resolve merge conflicts and get CI passing?

Hey @alice-i-cecile, I can fix the conflicts but I don't think I can fix the CI, we'd need a new version of cpal to be cut. From what I can see in the check-sources job, it's not desirable to patch cpal version with an arbitrary revision from their main branch (which contains the fix for Send+Sync issues in some of their types). How should we proceed here? I held off on writing the migration guide for this reason, but I could work on finishing that too if desirable.

alice-i-cecile · 2025-12-11T01:14:43Z

Can you track down the cpal authors and pester them (politely and patiently!) for a release? You're correct that we can't ship this with a git dependency.

Co-authored-by: Rob Parrett <robparrett@gmail.com>

mnmaita · 2026-03-24T22:45:00Z

Btw should we also update this one and this other one in that readme template?

Yes please! Once that's done I'll merge this.

Done, thanks everyone for pushing this one forward. It was a tough one! 😅

# Objective `libc++_shared.so` is no longer needed after #20323 ## Solution Remove unused `dummy.cpp` and cmake in Android examples. ## Testing Run: ```sh cargo ndk -P 26 -t arm64-v8a build -o examples/mobile/android_example/app/src/main/jniLibs -p bevy_mobile_example cd examples/mobile/android_example ./gradlew assembleDebug adb install -r ./app/build/outputs/apk/debug/app-debug.apk ```

alice-i-cecile added A-Audio Sounds playback and modification C-Dependencies A change to the crates that Bevy depends on S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Jul 29, 2025

github-project-automation bot added this to Audio (Old) Jul 29, 2025

alice-i-cecile added the M-Migration-Guide A breaking change to Bevy's public API that needs to be noted in a migration guide label Jul 29, 2025

mnmaita mentioned this pull request Aug 11, 2025

Update rodio requirement from 0.20 to 0.21 #20511

Closed

mnmaita force-pushed the mnmaita/dependabot/cargo/cpal-0.16 branch from 7111175 to 51b8311 Compare October 22, 2025 12:57

mnmaita marked this pull request as ready for review October 22, 2025 13:47

mnmaita commented Oct 22, 2025

View reviewed changes

mnmaita mentioned this pull request Oct 27, 2025

wasapi: Stream no longer Sync RustAudio/cpal#1038

Closed

mnmaita force-pushed the mnmaita/dependabot/cargo/cpal-0.16 branch from b85a940 to 6248b2e Compare October 27, 2025 23:41

alice-i-cecile requested changes Oct 29, 2025

View reviewed changes

github-project-automation bot moved this to Needs Update in Audio (Old) Oct 29, 2025

mnmaita force-pushed the mnmaita/dependabot/cargo/cpal-0.16 branch from 6248b2e to 9ef8982 Compare October 29, 2025 19:14

alice-i-cecile added this to the 0.18 milestone Nov 23, 2025

alice-i-cecile removed this from the 0.18 milestone Dec 10, 2025

alice-i-cecile added S-Blocked This cannot move forward until something else changes and removed S-Waiting-on-Author The author needs to make changes or address concerns before this can be merged labels Dec 11, 2025

mnmaita and others added 21 commits March 24, 2026 23:43

Fixes licence exceptions for symphonia

298d57b

Removes minimp3 usage and fixes fallback features

52f543c

Updates cargo_features.md

2071696

Removes obsolete android_shared_stdcxx feature

ac8758b

TEMPORARY: cpal patch to fix Send + Sync issue

d8f259e

Reexports rodio's ChannelCount and SampleRate aliases

9e56f59

TEMPORARY: rodio patch for latest cpal compatibility

b87a126

Fixes decodable example

e4f3850

Enables lewton when using audio-all feature

eb30f93

Adds migration guide

057e21b

Fix markdown lints

bd03421

Updates cpal to 0.17

2da6feb

Reverts symphonia as default feature

0180221

TEMPORARY: Updates rodio patch revision

e39cc3f

Turns audio-all into a collection + fix feature docs

d795275

Updates renamed rodio types

290a606

Updates disable-audio.patch

1239596

Updates rodio to 0.22

20bff64

Apply suggestions from code review

cfc1577

Co-authored-by: Rob Parrett <robparrett@gmail.com>

Sets minimum Android API version to 26 in validation-jobs.yml

0b1d5ad

Updates EXAMPLE_README template

0edc1b1

mnmaita force-pushed the mnmaita/dependabot/cargo/cpal-0.16 branch from 6aefc6b to 0edc1b1 Compare March 24, 2026 22:44

alice-i-cecile added this pull request to the merge queue Mar 24, 2026

Merged via the queue into bevyengine:main with commit a80470f Mar 25, 2026
42 checks passed

github-project-automation bot moved this from Needs SME Triage to Done in Audio Mar 25, 2026

leomeinel mentioned this pull request Mar 25, 2026

examples: Use single up-to-date android example #23491

Open

beicause mentioned this pull request Mar 28, 2026

Remove cmake and dummy.cpp in Android example #23548

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Update Rodio to 0.22#20323

Update Rodio to 0.22#20323
alice-i-cecile merged 35 commits intobevyengine:mainfrom
mnmaita:mnmaita/dependabot/cargo/cpal-0.16

mnmaita commented Jul 29, 2025 •

edited

Loading

Uh oh!

mnmaita commented Jul 29, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

nyfair commented Oct 16, 2025

Uh oh!

mnmaita commented Oct 22, 2025

Uh oh!

mnmaita Oct 22, 2025

Uh oh!

alice-i-cecile left a comment

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

alice-i-cecile commented Dec 10, 2025

Uh oh!

mnmaita commented Dec 10, 2025

Uh oh!

alice-i-cecile commented Dec 11, 2025

Uh oh!

mnmaita commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

Uh oh!

Conversation

mnmaita commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Objective

Solution

Testing

Uh oh!

mnmaita commented Jul 29, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions bot commented Jul 29, 2025

Uh oh!

nyfair commented Oct 16, 2025

Uh oh!

mnmaita commented Oct 22, 2025

Uh oh!

mnmaita Oct 22, 2025

Choose a reason for hiding this comment

Uh oh!

alice-i-cecile left a comment

Choose a reason for hiding this comment

Uh oh!

github-actions bot commented Oct 29, 2025

Uh oh!

alice-i-cecile commented Dec 10, 2025

Uh oh!

mnmaita commented Dec 10, 2025

Uh oh!

alice-i-cecile commented Dec 11, 2025

Uh oh!

mnmaita commented Mar 24, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

8 participants

mnmaita commented Jul 29, 2025 •

edited

Loading

mnmaita commented Jul 29, 2025 •

edited

Loading