Open
Conversation
|
Question here: am I correct in thinking that this would not work for emails with attachments? As SNS has a limit of 150 kb for the email size? |
|
Is it possible to merge this pr? Or do you have any idea for amazon ses? |
|
Could this PR corrected and merged ? |
aihoshistar
approved these changes
May 26, 2023
|
Could this PR be merged ? |
|
@mabadir is there a fixture for this to make sure the request gets parsed correctly? |
|
Any news on this? |
Author
|
Hi All, |
Member
|
Happy to merge this as soon as I get some confirmations of people who test this with SES, since we don't use it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
8 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hello,
This PR basically adds SES support to Laravel Mailbox. It is overcoming few shortcomings from Amazon SNS.
Appreciate your review and comments.