Open
Conversation
obreitwi
force-pushed
the
pr/DebuggeeAction
branch
from
39bbb9b to
ed15e8e
Compare
* Introduce DebuggeeAction as alias for StateT Debugee IO
-> Get rid of Debuggee being passed explicitly into IO actions,
turning function signatures like
(Debuggee -> ... -> IO a)
into
(... -> DebuggeeAction a)
* This is done in order to track state in Debuggee in the future.
* Introduce a lot of liftIO :(
obreitwi
force-pushed
the
pr/DebuggeeAction
branch
from
ed15e8e to
97bc6aa
Compare
Contributor
|
@obreitwi Thanks for submitting this (and #33). I've been working on the GHC side of things for the past month, but I will get around to reviewing this soon. Also not that the the official repo has now moved to https://gitlab.haskell.org/ghc/ghc-debug. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
DebuggeeActionas alias forStateT Debugee IO→ Get rid of Debuggee being passed explicitly into IO actions, turning function signatures like
(Debuggee -> ... -> IO a)into
(... -> DebuggeeAction a)This is done in order to track state in Debuggee in the future.
Introduce a lot of
liftIO:(