Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 7 additions & 0 deletions docs/b2b-edition/specs/storefront/storefront/rfq.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -401,6 +401,13 @@ paths:
type: integer
example: "1745872023"
description: "The [Unix timestamp](https://www.unixtimestamp.com/) for when the sales quote was created."
- name: uuid
in: query
required: true
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[info]
I think it makes sense to show this as required, but for quotes created before the flag is enabled, it is technically not required as these quotes won't have UUIDs.

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

[suggestion]

To Keelan's point, perhaps worth specifying this in the description 🤔
Otherwise Developers will find it odd to expect this as a required field but having nothing to pass in for old quotes

schema:
type: string
example: "1a2b3c4d"
Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
example: "1a2b3c4d"
example: "3f7a9c0e-6d21-4f5c-b8a1-2e9d4c7b1a63"

🍹 More like a UUID

description: "The quote's secondary alphanumeric identifier."
responses:
"200":
description: OK
Expand Down