Refactor db.ts for conditional database imports#240
Open
izzudin96 wants to merge 1 commit intobigcommerce:mainfrom
Open
Refactor db.ts for conditional database imports#240izzudin96 wants to merge 1 commit intobigcommerce:mainfrom
izzudin96 wants to merge 1 commit intobigcommerce:mainfrom
Conversation
Refactor database import to use require for conditional loading based on DB_TYPE.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Refactor database import to use require for conditional loading based on DB_TYPE.
What?
Getting error when
DB_TYPEis set tomysql.FirebaseAppError: Failed to parse private key: Error: Invalid PEM formatted message. at new ServiceAccount
Why?
Fix error when using mysql
Testing / Proof
No error after this change when using mysql
@bigcommerce/api-client-developers