Fix PEM format private key and certificate handling in WeChat Pay config#3712
Merged
binarywang merged 3 commits intodevelopfrom Nov 15, 2025
Merged
Fix PEM format private key and certificate handling in WeChat Pay config#3712binarywang merged 3 commits intodevelopfrom
binarywang merged 3 commits intodevelopfrom
Conversation
- Add detection for PEM format strings vs Base64 format in loadConfigInputStream - PEM format strings (with -----BEGIN/-----END headers) are now passed through directly - Base64 format strings continue to be decoded as before - Fixes InvalidKeySpecException when using setPrivateKeyString() with PEM content - Resolves JDK 21 compatibility issue with WeChat Pay v3 API initialization Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
- Add test for setPrivateCertString() with PEM format content - Verify that both private key and certificate PEM formats work correctly - Ensure backward compatibility with Base64 format is maintained - Complete fix for JDK 21 compatibility issue #3680 Co-authored-by: binarywang <1343140+binarywang@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] 4.7.0 v3请求构造异常!无效的密钥格式
Fix PEM format private key and certificate handling in WeChat Pay config
Sep 22, 2025
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
loadConfigInputStreammethod inWxPayConfigwas incorrectly applying Base64 decoding to all string inputs, causing failures when users provided PEM format private keys or certificates viasetPrivateKeyString()orsetPrivateCertString().Problem
When users called:
The SDK would throw
WxRuntimeException: 无效的密钥格式(Invalid Key Format) because:loadConfigInputStreamalways applied Base64 decoding to string inputs-----BEGIN PRIVATE KEY-----) with characters that are invalid in Base64IllegalArgumentException: Illegal base64 character 2d(hyphen character)PemUtils.loadPrivateKey()Solution
Added intelligent format detection to distinguish between:
-----BEGINand-----ENDmarkers): Pass through as UTF-8 bytes forPemUtilsto handleChanges
loadConfigInputStreammethod with smart format detectionStandardCharsetsimport for proper UTF-8 encodingTesting
The fix handles all scenarios correctly:
This resolves WeChat Pay v3 API initialization failures in JDK 21 environments while preserving compatibility with existing implementations.
Fixes #3680.
✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.