Open
Conversation
a-wing
requested changes
Apr 1, 2026
Member
a-wing
left a comment
a-wing
left a comment
There was a problem hiding this comment.
There have a very import problem:
Live777 support mutil-stream:
- each stream include a datachannel
- each datachannel should use independent udp port
a-wing
reviewed
Apr 8, 2026
Member
a-wing
left a comment
a-wing
left a comment
There was a problem hiding this comment.
- Rename add
ptz_udp=>channelordatachannel - Merge datachannel some config and add example
conf/live777.toml - Signed CLA: https://github.com/binbat/live777/blob/main/.github/CLA.md#list-of-contributors
Member
|
BTW: Must resolved this conflicts |
a-wing
requested changes
Apr 9, 2026
a-wing
reviewed
Apr 10, 2026
Member
a-wing
left a comment
a-wing
left a comment
There was a problem hiding this comment.
- Need check each commit can pass CI
formatandlint - Add some unit test
Comment on lines
+4
to
+5
| # listen_addr:listen_port - liveion listens here for replies from downstream | ||
| # target_host:target_port - liveion sends DataChannel messages to this address |
Member
There was a problem hiding this comment.
listen_addr:listen_port => listen_host:listen_port
Usually listen_addr = listen_host + listen_port
Comment on lines
+47
to
+57
| // Format addresses, wrapping IPv6 in brackets | ||
| let target = if target_host.contains(':') { | ||
| format!("[{}]:{}", target_host, target_port) | ||
| } else { | ||
| format!("{}:{}", target_host, target_port) | ||
| }; | ||
| let bind_addr = if listen_addr.contains(':') { | ||
| format!("[{}]:{}", listen_addr, listen_port) | ||
| } else { | ||
| format!("{}:{}", listen_addr, listen_port) | ||
| }; |
Member
There was a problem hiding this comment.
Comment on lines
+468
to
+479
| // DataChannel ↔ UDP bidirectional forwarding. | ||
| // Messages from the WHIP publisher arrive on the subscribe channel. | ||
| let dc_rx = self.data_channel_forward.subscribe.subscribe(); | ||
| let dc_tx = self.data_channel_forward.publish.clone(); | ||
| let stream_cfg = self.ptz_udp.streams.get(&self.stream).cloned(); | ||
| super::channel::spawn_channel( | ||
| self.stream.clone(), | ||
| dc_rx, | ||
| dc_tx, | ||
| stream_cfg, | ||
| ) | ||
| .await; |
Member
There was a problem hiding this comment.
If has stream no set about data_channel config. We shouldn't start any data_channel function
Comment on lines
+59
to
+68
| let socket = match UdpSocket::bind(&bind_addr).await { | ||
| Ok(s) => { | ||
| info!("channel [{}]: listen={} target={}", stream, bind_addr, target); | ||
| Arc::new(s) | ||
| } | ||
| Err(e) => { | ||
| warn!("channel [{}]: bind socket failed: {}", stream, e); | ||
| return; | ||
| } | ||
| }; |
Member
There was a problem hiding this comment.
There function should add a return Error
When UdpSocket::bind has error, should stop and return Error
Comment on lines
+73
to
+111
| tokio::spawn(async move { | ||
| loop { | ||
| match dc_rx.recv().await { | ||
| Ok(data) => { | ||
| if let Err(e) = socket_dc.send_to(&data, &target).await { | ||
| warn!("channel [{}]: send to {} failed: {}", stream_dc, target, e); | ||
| } else { | ||
| debug!("channel [{}]: DC->UDP {} bytes -> {}", stream_dc, data.len(), target); | ||
| } | ||
| } | ||
| Err(broadcast::error::RecvError::Lagged(n)) => { | ||
| warn!("channel [{}]: lagged, dropped {} messages", stream_dc, n); | ||
| } | ||
| Err(broadcast::error::RecvError::Closed) => { | ||
| info!("channel [{}]: channel closed", stream_dc); | ||
| break; | ||
| } | ||
| } | ||
| } | ||
| }); | ||
|
|
||
| // --- UDP -> DataChannel (passthrough, no wrapping) --- | ||
| tokio::spawn(async move { | ||
| let mut buf = vec![0u8; 1024]; | ||
| loop { | ||
| match socket.recv_from(&mut buf).await { | ||
| Ok((n, addr)) => { | ||
| let data = buf[..n].to_vec(); | ||
| debug!("channel [{}]: UDP->DC {} bytes from {}", stream, n, addr); | ||
| if let Err(e) = dc_tx.send(data) { | ||
| warn!("channel [{}]: forward to DC failed: {}", stream, e); | ||
| } | ||
| } | ||
| Err(e) => { | ||
| warn!("channel [{}]: recv_from failed: {}", stream, e); | ||
| } | ||
| } | ||
| } | ||
| }); |
Member
There was a problem hiding this comment.
There has two tokio::spawn. I think merge only one tokio::spawn is more good
a-wing
reviewed
Apr 13, 2026
a-wing
requested changes
Apr 17, 2026
|
|
||
| glob = "0.3" | ||
| url = { version = "2.5", optional = true } | ||
| url = { workspace = true, optional = true } |
Member
There was a problem hiding this comment.
If you want to remove url use std parse url, there no change here.
If you want to use url, change here is ok
Codecov Report❌ Patch coverage is
... and 57 files with indirect coverage changes 🚀 New features to boost your workflow:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.