Closed
Conversation
r1b2ns
force-pushed
the
fix/ui-list-transactions
branch
from
c4215f0 to
36c7dcb
Compare
r1b2ns
force-pushed
the
fix/ui-list-transactions
branch
from
36c7dcb to
eb492ef
Compare
Collaborator
|
great catch! I must have not seen a few things like this when I refactored some ui recently to help out main screen dynamic type stuff. on the screen you show when I was on your branch I the below screenshot with a bunch of transactions so whatever I did must still have things messed up whether you have transactions no transactions I tried to iterate on what you did further by just embedding things in a scrollview #348 , if you like that change then feel free to either apply it to this PR or ack my pr, either is fine with me 
|
Collaborator
Author
|
Closing it in favor of #348. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
On the transactions screen, when the total number of items doesn’t fill the screen, the Transactions list gets vertically centered
Problem
Simulator.Screen.Recording.-.iPhone.16.-.2025-11-24.at.14.50.26.mp4
Fix
Uploading Simulator Screen Recording - iPhone 16 - 2025-11-24 at 15.53.55.mp4…
Notes to the reviewers
Changelog notice
Checklists
All Submissions:
.swift-formatfile