feat: Add Multipath descriptor support#238
Open
tvpeter wants to merge 3 commits intobitcoindevkit:masterfrom
Open
feat: Add Multipath descriptor support#238tvpeter wants to merge 3 commits intobitcoindevkit:masterfrom
tvpeter wants to merge 3 commits intobitcoindevkit:masterfrom
Conversation
- Update wallet initialization/creation to check if external descriptor is multipath for both persisted and non persisted wallets - add error variant for when both multipath and internal descriptors are provided
tvpeter
force-pushed
the
feat/multipath-desc-support
branch
from
9d2027d to
c63d511
Compare
Pull Request Test Coverage Report for Build 21787788027Details
💛 - Coveralls |
tvpeter
force-pushed
the
feat/multipath-desc-support
branch
from
c63d511 to
1433513
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR enables support for BIP389 multipath descriptors. It uses the existing
external descriptorand verifies whether the provided descriptor is a multipath descriptor. If it is, a wallet will be created using theWallet::create_from_two_path_descriptor()method. If not, the standard wallet creation logic will be applied.Fixes #195
Changelog notice
Checklists
All Submissions:
cargo fmtandcargo clippybefore committingNew Features:
CHANGELOG.md